Skip to content

🎨 Palette: [UX improvement] Add keyboard hints and score accessibility to Mario game#148

Open
EiJackGH wants to merge 1 commit into
mainfrom
palette/mario-ux-accessibility-14421938612824928819
Open

🎨 Palette: [UX improvement] Add keyboard hints and score accessibility to Mario game#148
EiJackGH wants to merge 1 commit into
mainfrom
palette/mario-ux-accessibility-14421938612824928819

Conversation

@EiJackGH

Copy link
Copy Markdown
Owner

💡 What:

  • Added an on-screen hint (#controls) instructing the user to "Press Space or Up Arrow to jump".
  • Added aria-live="polite" and aria-atomic="true" to the #score element.
  • Removed the problematic standard library venv entry from requirements.txt.

🎯 Why:

  • Users were previously not given any instructions on how to interact with the Mario game interface, leading to friction.
  • The score dynamically updates using JavaScript without page reloads; adding ARIA properties ensures screen readers correctly announce these changes as the user plays.
  • The venv entry in requirements.txt was actively breaking local pip install workflows, preventing automated tests from running.

📸 Before/After:

  • A new translucent #controls hint box has been added nicely to the top right corner of the game area.

Accessibility:

  • Added aria-live and aria-atomic tags to ensure dynamic updates to the score are accessible to users with screen readers.
  • Ensured keyboard shortcuts for playing are clearly communicated to the user.

PR created automatically by Jules for task 14421938612824928819 started by @EiJackGH

Added screen reader support for dynamic game score using aria-live.
Added visual keyboard controls hint for better game usability.
Removed invalid `venv` entry from requirements.txt to fix test environment.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

Copy link
Copy Markdown

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant